Skip to content

Conversation

soujay
Copy link
Contributor

@soujay soujay commented Sep 8, 2025

This PR addresses Port label overlaps input field on initial load in the installer

Tested this with the build artifacts
image

@soujay soujay changed the title adjust port label position Adjust port label position in set up installer Sep 8, 2025
@soujay soujay force-pushed the installer-port-label-overlap branch from c3abb46 to ad614d6 Compare September 9, 2025 01:52
@soujay soujay marked this pull request as ready for review September 9, 2025 02:29
@soujay soujay added this to the 2.3.0 milestone Sep 9, 2025
@danielmarbach
Copy link
Contributor

The Port text box is shifted compared to the other fields (ServiceControl URI and Monitoring URI), which makes the layout feel inconsistent. Align the Port field with the text boxes below. Either give it the same width or align its left edge to the start of the other input fields. That way all input fields create a clean vertical line. My preference would be to keep it short but left align

The bold Note: is colliding with “The above…” and reduces readability. Add spacing after Note: or put “Note:” on its own line and then the explanatory text on the next line, indented slightly.

What is also visually a bit weird is the following:

We have checkboxes that have a bold text with a non-bold URI label under it with a text box for filling in the URI. The port one is following a different visual pattern (don't know if that is a problem, just noting it down here). I wonder how it would look if the text "Specify the port number..." is bold, the Port label non-bold and the port input field left aligned with the other text input fields.

@danielmarbach danielmarbach merged commit 09c46ec into master Sep 12, 2025
5 checks passed
@danielmarbach danielmarbach deleted the installer-port-label-overlap branch September 12, 2025 07:03
@ngallegos ngallegos added the Type: Bug Type: Bug label Sep 17, 2025
@soujay soujay changed the title Adjust port label position in set up installer Port label overlaps input field on initial load in the set up installer Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServicePulse Setup - Port label overlaps input field on initial load until user interaction
4 participants